Bug fix for compatible mode in UETableProducer. (Same as #12227)

[mverwe]

Does not have impact on reconstruction. Bug fix for DB generation.

[cmsbuild]

A new Pull Request was created by @mverwe (Marta Verweij) for CMSSW_7_6_X.

Bug fix for compatible mode in UETableProducer. (Same as #12227)

It involves the following packages:

RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @richard-cms, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9427/console

[cmsbuild]

+1
Tested at: 15b17e4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12239/9427/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12239/9427/summary.html

[cvuosalo]

@mverwe: The static analyzer has flagged a thread-safety problem in UETableProducer.cc. Please fix this problem:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12239/9427/llvm-analysis/report-651349.html#EndPath

[mverwe]

Fixed the multi-threading safety and added necessary description. edmCheckMultithreading does not complain anymore.

[cmsbuild]

Pull request #12239 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #12239 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9467/console

[cmsbuild]

+1
Tested at: 8550b00
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12239/9467/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12239/9467/summary.html

[cvuosalo]

+1

For #12239 8550b00

Bug fix in Heavy Ion UETableProducer for DB generation. There should be no change in monitored quantities. #12227 is the 75X version of this PR, and it has already been merged.

The code change is satisfactory. Jenkins tests against baseline CMSSW_7_6_X_2015-11-04-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1