Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a consume to fix DumpFedRawDataProduct from crashing. #12265

Merged
merged 1 commit into from
Nov 5, 2015

Conversation

matz-e
Copy link
Contributor

@matz-e matz-e commented Nov 5, 2015

This analyzer is used to debug the L1T unpacking development. It would be nice to have it fixed. Should this also be added to the 8_0_X branch?

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_7_6_X.

Add a consume to fix DumpFedRawDataProduct from crashing.

It involves the following packages:

DataFormats/FEDRawData

@mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Nov 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1
80X will be updated automatically in this case.

cmsbuild added a commit that referenced this pull request Nov 5, 2015
Add a consume to fix DumpFedRawDataProduct from crashing.
@cmsbuild cmsbuild merged commit fac89dd into cms-sw:CMSSW_7_6_X Nov 5, 2015
@matz-e matz-e deleted the fix-fed-raw-dump branch September 15, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants