Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data mixer tuning for HCAL and ECAL #12297

Merged
merged 1 commit into from
Nov 10, 2015

Conversation

fratnikov
Copy link

Data Mixer code tune up

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

A new Pull Request was created by @fratnikov (Fedor Ratnikov) for CMSSW_8_0_X.

data mixer tuning for HCAL and ECAL

It involves the following packages:

Configuration/StandardSequences
SimGeneral/DataMixingModule

@cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Nov 6, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9504/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

@civanch
Copy link
Contributor

civanch commented Nov 9, 2015

+1

davidlange6 added a commit that referenced this pull request Nov 10, 2015
data mixer tuning for HCAL and ECAL
@davidlange6 davidlange6 merged commit 30eb309 into cms-sw:CMSSW_8_0_X Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants