clangSA update symbols.py script and fix potential bug in fixAnonNS(). #12332
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_0_X. clangSA update symbols.py script and fix potential bug in fixAnonNS(). It involves the following packages: Utilities/StaticAnalyzers @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
| { | ||
| clang::QualType t = D->getType(); | ||
| clang::ento::PathDiagnosticLocation DLoc = | ||
| clang::ento::PathDiagnosticLocation::createBegin(D, BR.getSourceManager()); | ||
| if ( support::isSafeClassName( t.getCanonicalType().getAsString() ) ) return; | ||
| if ( ! support::isDataClass( support::getQualifiedName(*RD) ) ) return; | ||
| WalkAST walker(this,BR, mgr.getAnalysisDeclContext(RD), (*(RD->ctor_begin()))->getMostRecentDecl() ) ; |
There was a problem hiding this comment.
This caused a crash because RD->ctor_begin() returned a null pointer. Making fixAnonNS a helper function removed the need to instantiate a WalkAST to get access to fixAnonNS.
|
Please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
clangSA update symbols.py script and fix potential bug in fixAnonNS().
No description provided.