-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pedestal EB RMS threshold. Add chi2 cut on DQM timing. #12348
Conversation
A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_7_5_X. Fix Pedestal EB RMS threshold. Add chi2 cut on DQM timing. It involves the following packages: DQM/EcalMonitorClient @cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
please test |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
-1 DAS Error you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Fix Pedestal EB RMS threshold. Add chi2 cut on DQM timing.
Fix Pedestal RMS threshold for EB to ( G1:1.0, G6:1.2, G12:2.0 ) ADC.
Add chi2 cut on rechits for DQM Timing.