-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FileInPath test in FWCore/PythonParameterSet #12376
Conversation
A new Pull Request was created by @wmtan for CMSSW_8_0_X. Fix FileInPath test in FWCore/PythonParameterSet It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
dc6bbf1
to
c4b7f19
Compare
Pull request #12376 was updated. @smuzaffar, @Dr15Jones can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@davidlange6 @Dr15Jones Since this problem occurs in all releases, please let me know to which releases, if any, this fix should be back ported. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Fix FileInPath test in FWCore/PythonParameterSet
@wmtan , looks like test is still failing in IB env. Here is what we do in IB to run unit tests, may be you try this too to check if it locally works for you
|
@smuzaffar Yes, I have reproduced this using your script. I'll investigate. |
The above receipe will not take much time. It is a way for running unit tests from the release area without re-building any thing locally. |
@smuzaffar Unfortunately, although I can reproduce the error, I cannot debug it. I cannot edit the test on a CERN machine. If I set this up on my own machine, I can still reproduce the error, but any changes I make in the test do not affect the test. It always runs the test exactly as it is in the IB, and does not see my modifications. |
This needs to be tested as I cannot be 100% sure that this fixes the test, as I can't be certain that I've reproduced the conditions under which the test is run in the IB. Nonetheless, it should fix it.
There are two separate problems fixed by this PR. Problem 2) caused the test failure.