-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete conditional compilations in Framework only #12420
Remove obsolete conditional compilations in Framework only #12420
Conversation
A new Pull Request was created by @wmtan for CMSSW_8_0_X. It involves the following packages: DataFormats/Common @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@VinInn This is the cleanup of obsolete preprocessor directives, but only in Core Software, not in all of CMSSW. |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 987f142 ---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS you can see the results of the tests here: |
Test failures are not related to this pull request since they are already see in the IBs. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
…tions Remove obsolete conditional compilations in Framework only
-1 Tested at: 987f142 ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
For some reason, double initial and final underscores appear in this comment as single underscores. They should be double.
This PR removes the use of obsolete conditional compilations from the framework, now that C++11 and ROOT6 are supported from now on.
In particular, _ CINT_, _ MAKECINT_, _ GCCXML_, _ REFLEX_, and CMS_NOCXX11 are no longer ever set, GCC11_OVERRIDE always evaluates to "override", and ROOT_VERSION_CODE is always larger that the ROOT releases to which it is being compared.
Note that _ ROOTCLING_ is still used, so uses of _ ROOTCLING_ are untouched by this PR.
This clean up is for Core Software only. Code outside core software is not touched.
This PR should not affect the compiled code at all.
Note also that all uses of std::atomic in the framework are transient, so they do not need to be protected from ROOT. This is unchanged by this PR.