-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds HLTPixelActivityHFSumEnergyFilter module #12483
Conversation
A new Pull Request was created by @ttrk for CMSSW_7_5_X. It involves the following packages: HLTrigger/special @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
// class declaration | ||
// | ||
|
||
class HLTPixelActivityHFSumEnergyFilter : public HLTFilter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is an HLTFilter...
Since you code a fillDescriptions method, no cfi file is needed. |
bool accept = false; | ||
double thres = slope_ * sumE - offset_; | ||
if(sumE > eMin_HF_ && clusterSize < thres ) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of clusterSize < thres better std::abs(clusterSize - thres) > someConfigurableValue
to check deviation from (almost) equality?
Thank you very much for the comments. We will update the changes properly and supersede this PR with a new one. At the moment, we close this PR. |
adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483)
adds HLTPixelActivityHFSumEnergyFilter module. This filter checks correlation between number of pixel clusters and HF energy sum. The idea is to have a filter firing when the expected correlation is broken.
At the moment there is no python config. that runs this module.
Question : Is a .cfi file needed for this module to be available in confdb ?
Remark 1 : This module is NOT for the pp reference run.
Remark 2 : This module is for PbPb run.
@mverwe
@kkrajczar
@icali