Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds HLTPixelActivityHFSumEnergyFilter module #12483

Closed
wants to merge 2 commits into from

Conversation

ttrk
Copy link
Contributor

@ttrk ttrk commented Nov 18, 2015

adds HLTPixelActivityHFSumEnergyFilter module. This filter checks correlation between number of pixel clusters and HF energy sum. The idea is to have a filter firing when the expected correlation is broken.
At the moment there is no python config. that runs this module.

Question : Is a .cfi file needed for this module to be available in confdb ?
Remark 1 : This module is NOT for the pp reference run.
Remark 2 : This module is for PbPb run.

@mverwe
@kkrajczar
@icali

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ttrk for CMSSW_7_5_X.

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

// class declaration
//

class HLTPixelActivityHFSumEnergyFilter : public HLTFilter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is an HLTFilter...

@Martin-Grunewald
Copy link
Contributor

Since you code a fillDescriptions method, no cfi file is needed.

bool accept = false;
double thres = slope_ * sumE - offset_;
if(sumE > eMin_HF_ && clusterSize < thres )
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of clusterSize < thres better std::abs(clusterSize - thres) > someConfigurableValue
to check deviation from (almost) equality?

@ttrk
Copy link
Contributor Author

ttrk commented Nov 18, 2015

Thank you very much for the comments. We will update the changes properly and supersede this PR with a new one. At the moment, we close this PR.

@ttrk ttrk closed this Nov 18, 2015
cmsbuild added a commit that referenced this pull request Nov 20, 2015
adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants