HIN ecal pulse dqm

[rkunnawa]

This is a DQMOffline module to check the chi squared of the fit functions in the ECAL. required to check during the PbPb data taking.

[cmsbuild]

A new Pull Request was created by @rkunnawa (Raghav Kunnawalkam Elayavalli) for CMSSW_7_5_X.

It involves the following packages:

DQMOffline/Ecal

@cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[deguio]

please test

[deguio]

this is very late. it won't go in for HI.

[deguio]

please submit to 80x first

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9837/console

[rkunnawa]

@deguio
This is for the offline DQM monitoring. Since you say that it wont go in for HI, does that mean that we have to run it ourself? @yetkinyilmaz @mandrenguyen @richard-cms
regarding 80X, Ive been testing it on 80X since last night, but a lot of the workflows in the matrix (-s) are failing due to file read errors. I ran the HIN workflow locally and it seems fine. If its ok, i can submit that one now. I tested it on two of the latest IBs.

[mandrenguyen]

@deguio
Why won't it go in for heavy ions?
That's obviously the only thing it's needed for.
There will be a release built today.
If you sign, it will be merged.

[deguio]

@mandrenguyen
I'm sorry, it doesn't work like this. this is a new piece of code. the policy is to have it merged in the dev release first (80x) and then backported to closed cycles. submitting few hours before the release build is not the right approach. we (and the developers) have been preparing for this release since weeks.
F.

[cmsbuild]

+1
Tested at: a90b976
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12484/9837/summary.html

[yetkinyilmaz]

Hi @deguio , is the 755 patch release intended for a specific purpose other than heavy-ions?
If it is not particularly heavy-ion aimed release, then I think we need another patch release in order to have this module in our DQM for the prompt reco of the heavy-ions.

[deguio]

+1
the code is ok. up to you to convince the release managers that this is crucial for the coming 756 build intended to be used for HI data taking next week.
@davidlange6

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12484/9837/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[slava77]

@deguio what's a preferred way of booking 2D histograms?
book2D should let you book internally using arguments instead of making a histogram first

[yetkinyilmaz]

Hi Slava;
if this is not particularly harmful for a known reason, we should not
change it in this PR.

On 19/11/15 13:21, Slava Krutelyov wrote:

In DQMOffline/Ecal/plugins/ECALMultifitAnalyzer_HI.cc
#12484 (comment):

• ee_chi2_jet30 = 0;
• ee_errors_jet30 = 0;

• const int nBins = 500;
• const float maxChi2 = 70;
• const float maxError = 0.5;

• TH2F * hProfile_Chi2 = new TH2F("hProfile_Chi2","",nBins, -5, 5, nBins, 0, maxChi2);
• TH2F * hProfile_Err = new TH2F("hProfile_Err","",nBins, -5, 5, nBins, 0, maxError);

• eb_chi2 = iBooker.book1D("rechit_eb_chi2","Rechit eb_chi2;chi2 fit value;",nBins,0,maxChi2);
• eb_chi2_eta = iBooker.book2D("rechit_eb_eta_Vs_mean_Chi2", hProfile_Chi2);
• eb_chi2_e5 = iBooker.book1D(Form("rechit_eb_chi2_e%2.0f", mRechitEnergyThreshold),Form("Rechit eb_chi2, e>%2.0fGeV;chi2 fit value;", mRechitEnergyThreshold),nBins,0,maxChi2);
• eb_chi2_e5_eta = iBooker.book2D(Form("rechit_eb_chi2_e%2.0f_eta", mRechitEnergyThreshold),hProfile_Chi2);
• eb_errors = iBooker.book1D("rechit_eb_errors","Rechit eb_errors;error on the energy;",nBins,0,maxError);
• eb_errors_eta = iBooker.book2D("rechit_eb_errors_eta",hProfile_Err);

@deguio https://github.com/deguio what's a preferred way of booking
2D histograms?
book2D should let you book internally using arguments instead of
making a histogram first

—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/12484/files#r45333540.

[slava77]

Hi Yetkin,
I'm not so familiar with good ways of booking DQM histograms.
This one seems fairly uncommon based on "git grep book2D"
Hence my question.

[yetkinyilmaz]

You are totally right, I'm also not familiar, if such a thing causes any
memory corruption it's not at all acceptable.
We need additional confirmation from someone who is sure such way of
booking is identical to alternatives.
Raghav says this is the way he was asked to use long time ago.
I assumed Federico's +1 includes this, Federico can you confirm?

On 19/11/15 13:30, Slava Krutelyov wrote:

In DQMOffline/Ecal/plugins/ECALMultifitAnalyzer_HI.cc
#12484 (comment):

• ee_chi2_jet30 = 0;
• ee_errors_jet30 = 0;

• const int nBins = 500;
• const float maxChi2 = 70;
• const float maxError = 0.5;

• TH2F * hProfile_Chi2 = new TH2F("hProfile_Chi2","",nBins, -5, 5, nBins, 0, maxChi2);
• TH2F * hProfile_Err = new TH2F("hProfile_Err","",nBins, -5, 5, nBins, 0, maxError);

• eb_chi2 = iBooker.book1D("rechit_eb_chi2","Rechit eb_chi2;chi2 fit value;",nBins,0,maxChi2);
• eb_chi2_eta = iBooker.book2D("rechit_eb_eta_Vs_mean_Chi2", hProfile_Chi2);
• eb_chi2_e5 = iBooker.book1D(Form("rechit_eb_chi2_e%2.0f", mRechitEnergyThreshold),Form("Rechit eb_chi2, e>%2.0fGeV;chi2 fit value;", mRechitEnergyThreshold),nBins,0,maxChi2);
• eb_chi2_e5_eta = iBooker.book2D(Form("rechit_eb_chi2_e%2.0f_eta", mRechitEnergyThreshold),hProfile_Chi2);
• eb_errors = iBooker.book1D("rechit_eb_errors","Rechit eb_errors;error on the energy;",nBins,0,maxError);
• eb_errors_eta = iBooker.book2D("rechit_eb_errors_eta",hProfile_Err);

Hi Yetkin,
I'm not so familiar with good ways of booking DQM histograms.
This one seems fairly uncommon based on "git grep book2D"
Hence my question.

—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/12484/files#r45334291.

[deguio]

@slava77 I saw that, but the same histo (TH2) is used to book multiple monitorElement. it is just convenient to have all the MEs with same binning and ranges. looks ok to me.

[slava77]

merge

I checked locally with HeavyIonsRun2 using 251721 and 261626. both run and the ECALMultifitAnalyzer_HI looks ok (not noisy and doesn't take much time)