-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an invalid use of a 'static' keyword in DQM/HcalDetDiagPedestalMonitor #12514
Conversation
…nitor. Also fix a mistake made in previous commit. These statics *were* actually used to store data in between the invocations. Fixed by making them class members.
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_8_0_X. It involves the following packages: DQM/HcalMonitorTasks @cmsbuild, @danduggan, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Fix an invalid use of a 'static' keyword in DQM/HcalDetDiagPedestalMonitor
Also fix a mistake made in previous commit.
These statics were actually used to store data in between the invocations.
Fixed by making them class members.
Related PR: #12495