-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filters for charged hadrons and muons that have bad track quality cau… #12515
filters for charged hadrons and muons that have bad track quality cau… #12515
Conversation
…sing very high-pT jets and MET tails
A new Pull Request was created by @clelange for CMSSW_7_6_X. It involves the following packages: RecoMET/METFilters @cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
Hi, Shouldn't the paths be also added to Giovanni |
@gpetruc Definitely. Should come today. |
Hi Giovanni, I added it in clelange@102ed50 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
// class declaration | ||
// | ||
|
||
class ChargedHadronTrackResolutionFilter : public edm::EDFilter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be thread-aware
better be edm::global::EDFilter
but may be faster to say edm::stream
Hi Slava, I think I should have implemented your comments on the code. Clemens |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@clelange please make a PR for 80X as well |
filters for charged hadrons and muons that have bad track quality cau…
@schoef @mariadalfonso does it actually make sense to add the two new filters to metFilters sequence, the "combined MET filters" result? |
…sing very high-pT jets and MET tails
If all PF bugs are fixed in 76X, this should not filter any events.