Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters for charged hadrons and muons that have bad track quality cau… #12515

Merged

Conversation

clelange
Copy link
Contributor

…sing very high-pT jets and MET tails
If all PF bugs are fixed in 76X, this should not filter any events.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @clelange for CMSSW_7_6_X.

It involves the following packages:

RecoMET/METFilters

@cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@gpetruc
Copy link
Contributor

gpetruc commented Dec 2, 2015

Hi,

Shouldn't the paths be also added to PhysicsTools/PatAlgos/python/slimming/metFilterPaths_cff.py ?

Giovanni

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

Pull request #12515 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

@schoef
Copy link
Contributor

schoef commented Dec 2, 2015

@gpetruc Definitely. Should come today.

@clelange
Copy link
Contributor Author

clelange commented Dec 2, 2015

Hi Giovanni, I added it in clelange@102ed50
Clemens

@cvuosalo
Copy link
Contributor

cvuosalo commented Dec 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10080/console

// class declaration
//

class ChargedHadronTrackResolutionFilter : public edm::EDFilter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be thread-aware
better be edm::global::EDFilter
but may be faster to say edm::stream

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

Pull request #12515 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

@clelange
Copy link
Contributor Author

clelange commented Dec 2, 2015

Hi Slava,

I think I should have implemented your comments on the code.

Clemens

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@slava77
Copy link
Contributor

slava77 commented Dec 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10093/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2015

@clelange please make a PR for 80X as well
If this gets merged first and we see that auto-forward-port to 80X went well that 80X PR could be closed.

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2015

+1

for #12515 d63d2a9

  • new filters added. The code looks somewhat reasonable. An alternative to selections made in the created filters is still desirable, since essentially all of it can be applied on either AOD or miniAOD.
  • jenkins tests pass; the comparisons with the baseline show no differences.

davidlange6 added a commit that referenced this pull request Dec 3, 2015
filters for charged hadrons and muons that have bad track quality cau…
@davidlange6 davidlange6 merged commit 4562f64 into cms-sw:CMSSW_7_6_X Dec 3, 2015
@slava77
Copy link
Contributor

slava77 commented Dec 3, 2015

@schoef @mariadalfonso does it actually make sense to add the two new filters to metFilters sequence, the "combined MET filters" result?

@clelange clelange deleted the ChargedHadronMuonRefFilter76X branch June 3, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants