Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HI-related products for pp runs in event content keep statements #12520

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 20, 2015

customize function from #12185
didn't work with event contents built in pure python from ConfigBuilder as used in event processing.
Making a kludge here for 75X.

cmsDriver.py worked, however. So, customs function can still be used there

@slava77
Copy link
Contributor Author

slava77 commented Nov 20, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_5_patchX milestone Nov 20, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_5_patchX.

It involves the following packages:

RecoEcal/Configuration
RecoEgamma/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @lgray this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.
Note that this branch is designed for requested bug fixes specific to the CMSSW_7_5_5 release.
If you wish to make a pull request for the CMSSW_7_5_X release cycle, please use the CMSSW_7_5_X branch instead

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor Author

slava77 commented Nov 20, 2015

+1

for #12520 93bb4c0

  • changes tested locally using short matrix, run2 134.[78]* workflows and a ppRun2 T0 prompt configuration with 4 threads in run 251721.
    • there are no changes in the tested workflows, except for the ppRun2 T0 prompt where the new products appear in the output (as expected)
    • the modules producing the products were already running. So, no changes there.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_5_patchX IBs after it passes the integration tests.

@slava77
Copy link
Contributor Author

slava77 commented Nov 20, 2015

[uhm, it took me an effort to remember that CMSSW_7_5_5_patchX jenins builds are not setup]

@slava77
Copy link
Contributor Author

slava77 commented Nov 20, 2015

merge

cmsbuild added a commit that referenced this pull request Nov 20, 2015
…hotonIsoContent

add HI-related products for pp runs in event content keep statements
@cmsbuild cmsbuild merged commit fd1b067 into cms-sw:CMSSW_7_5_5_patchX Nov 20, 2015
cmsbuild added a commit that referenced this pull request Nov 21, 2015
…hotonIsoContent

add HI-related products for pp runs in event content keep statements (same as #12520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants