ZDC unpacker update (as #12544 but also keep old zdc digis in HI AOD)

[slava77]

copy from #12544:

• [+] update working on compact FEDs readout
• slides at https://www.dropbox.com/s/jpb9tlf2sqta5ju/11-23-15_ZDCunpacker.pdf?dl=0
• also added the old ZDCDataFramesSorted_hcalDigis (for MC and old data if it ever comes up as AOD) as well as to reduce number of changes in the event content (one add, instead of "add and remove")

I made this PR in the interest of time, otherwise would have waited for @BetterWang to update.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9911/console

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X.

It involves the following packages:

EventFilter/CastorRawToDigi
RecoHI/HiEvtPlaneAlgos

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @richard-cms, @Martin-Grunewald, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[slava77]

+1

for #12549 557a937

• ~OK set of changes for a last minute set of fixes: the goal is to deliver zdc digis in HI datasets up to AOD
• jenkins tests in ZDC unpacker update URGENT #12544 75fd713 passed and showed no differences (this PR is just a one-line fix)

the number of unmapped digis is down .. I suppose this was the early indication of a broken code for the previous PR:
in run 262163 ppForward PD (black is 757):

From lack of DQM plot changes, it's clear that if there is any DQM for ZDC it's not magically picking up the castorDigis.
I suppose, zdc digi DQM will be done privately.

[slava77]

merge

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 557a937
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12549/9911/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b0b2550
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12549/9911/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12549/9911/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12549/9911/summary.html