Changes the energy threshold on the EcalDeadCellTriggerPrimitiveFilter

[kencall]

There is a subtle rounding error in EcalDeadCellTriggerPrimitiveFilter.cc. Adjusting the threshold to 127.49 GeV gives the correct functionality.

[cmsbuild]

A new Pull Request was created by @kencall for CMSSW_7_6_X.

It involves the following packages:

RecoMET/METFilters

@cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[schoef]

This is a critical fix for 76X mAOD v2 in the EcalDeadCellTPFilter mentioned in PPD:
https://indico.cern.ch/event/464265/contribution/0/attachments/1194402/1734903/15-11-25_News_PPD.pdf

@kencall please post the comparison plot

[kencall]

EcalTP.pdf
Comparison of threshold=127.49 vs. 127.5 using high pt QCD.

[gpetruc]

@davidlange6 @arizzi this is the other PR that was discussed at the PPD meeting to go into 76X MiniAOD v2

[mariadalfonso]

@monttj can you please start the testing and review this ? we need to have this bugFIX in the mAOD v2 76X

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10090/console

[cmsbuild]

+1
Tested at: 9b2406f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12557/10090/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12557/10090/summary.html

[slava77]

+1

for #12557 9b2406f

• small change in behavior to avoid round-off ambiguity
• jenkins tests pass and comparisons show no differences (ignore 25202 which had a problem getting minbias input files in the right order, which triggered large number of changes there).