Fix PackedCandidate vertex to post-packed value (76X)

[makortel]

Backport of #12558. Copied description:

I suspect #12367 was not enough to fully restore the 760pre7 behaviour of PackedCandidate packing given my 800per2 validation report
https://hypernews.cern.ch/HyperNews/CMS/get/relval/4324/16.html
Deleting also vertex_ in packBoth() seems to make a difference in the dxy/dz and track reference point histograms to the right direction.

Tested in 7_6_1 that short matrix runs, for results relied on the tests done in 80X for #12558.

@davidlange6 @arizzi @gpetruc

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

It involves the following packages:

DataFormats/PatCandidates

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10004/console

[cmsbuild]

-1

Tested at: 4e80f27
I found errors in the following unit tests:

---> test testDataFormatsPatCandidates had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12588/10004/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12588/10004/summary.html

[slava77]

+1

for #12588 4e80f27

• changes are in line with the description: post-packed value is served from the PackedCandidate
• jenkins tests pass (ignoring the unit test issue present in IB) and comparisons with baseline show differences only in packedCandidate validation where it is related to the vertex: values are not identical to the input PF candidate anymore
  e.g. 1330.0 wflow
  

[davidlange6]

this needs its unit test fixed, right?

[makortel]

The unit test failed already in the base IB, since the fix #12612 got merged later in CMSSW_7_6_X_2015-12-01-1100. Re-running the tests should succeed.

[davidlange6]

@cmsbuild, please test

ok - lets see..

On Dec 3, 2015, at 10:18 AM, Matti Kortelainen [email protected] wrote:

The unit test failed already in the base IB, since the fix #12612 got merged later in CMSSW_7_6_X_2015-12-01-1100. Re-running the tests should succeed.

—
Reply to this email directly or view it on GitHub.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10109/console

[cmsbuild]

-1

Tested at: 4e80f27
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12588/10109/summary.html

[makortel]

Digging from the log the error message seems to be

stat: cannot stat `dqm_empty.root': No such file or directory
read_missing_file_cfg.py ------------------------------------------------------------
03-Dec-2015 11:19:13 CET  Initiating request to open file file:dqm_missing.root
03-Dec-2015 11:19:14 CET  Successfully opened file file:dqm_missing.root
----- Begin Fatal Exception 03-Dec-2015 11:19:14 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Calling InputSource::readFile_
   [1] Opening DQM Root file
Exception Message:
Input file file:dqm_missing.root appears to be corrupted since it does not have the proper internal structure.
 Check to see if the file was closed properly.
----- End Fatal Exception -------------------------------------------------

To me it does not seem to be caused by this PR (anyway the testDataFormatsPatCandidates succeeds now).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12588/10109/summary.html