-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate data from PoolSource #12643
Conversation
A new Pull Request was created by @wmtan for CMSSW_8_0_X. It involves the following packages: IOPool/Input @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Remove duplicate data from PoolSource
PoolSource contains two data members that contain copies of the same parameters or data. This PR removes the duplication by moving these parameters up to PoolSource itself. In the secondary input source (EmbeddedRootSource), there is no such duplication, but the same data is also moved up to the source for consistency with PoolSource. This PR also does some C++11 modernization by adding missing override keywords and changing a few iterator loops to range based for loops.