-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Data GT for 2015 Run2 EOY Re-Reco, RunII Simulation with new SIM geometries, and Upgrade GT with Pixel conditions #12664
Conversation
A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_6_X. It involves the following packages: Configuration/AlCa @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
-1 DAS Error 140.53 step1 DAS Error you can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
@slava77 now it is done, I looked at all the GT one by one and amended the commits every time I was finding something non correct. |
@slava77 BTW, if you can share the tools for plot comparison, I'd like to run some 2015 RelVal with the new GT and compare the results w.r.t. the clean IB. |
On 12/5/15 12:29 AM, Salvatore Di Guida wrote:
instructions are available at
|
@slava77 thanks a lot for your detailed review. They all make sense to me, even if I would like to see in closest details the tracking changes (in principle they should improve the chi2). I will approve this and then post other plots I have started to look at (weekend taken by online operations and crappy home network). |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Updating Data GT for 2015 Run2 EOY Re-Reco
Hi @diguida , just a small request on my side : Could you make the tiltle of such PRs more explicit in the future ? I noticed that the upgrade simulation GT was also changed in this 'Updating Data GT for 2015 Run2 EOY Re-Reco" , I had hard time to find it ...(and you are also changing run1data and run2 simulation btw ... so the tiltle is really not explicit...) Thanks a lot. |
@boudoul a separate PR existed for a while: #12371, we decided to include that commit in this PR not to leave the upgrade GT behind. General comment: since we are trying to minimize the number of PRs for each release it's bound to happen again to have all the scenarios updated. Given the limited amount of characters available for the title we generally choose the most meaningful update. We can use (unless there are specific cases) a neutral "Updated Global Tags for all scenarios" |
I do, Thanks! |
Summary of Global Tag Changes
RunII Simulation
RunI Data
RunII Data
Upgrade simulation