Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small bug in the counter #12732

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Fix small bug in the counter #12732

merged 1 commit into from
Dec 15, 2015

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Dec 9, 2015

Fix small bug in the counter of max lumi to be integrated.

  • Mauro.

Fix small bug in the counter of max lumi to be integrated.
- Mauro.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

A new Pull Request was created by @dinardo (Mauro) for CMSSW_8_0_X.

It involves the following packages:

DQM/BeamMonitor

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Dec 14, 2015

please test

@deguio
Copy link
Contributor

deguio commented Dec 14, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10278/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 15, 2015
Fix small bug in the counter
@cmsbuild cmsbuild merged commit e96af7c into cms-sw:CMSSW_8_0_X Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants