EGM ID Update 80X

[lgray]

Forward port of #12738.

New photon ID added to 80X MiniAOD.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/EgammaTools
RecoEgamma/PhotonIdentification

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10229/console

[lgray]

@ikrav

[cmsbuild]

+1
Tested at: 28bb2aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12740/10229/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4d0e8c8
38213da
53dbd48
4cd76f3
0325e93
48bb44c
bd03d38
98e1a51
1d22413
078a607
01f21df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12740/10229/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12740/10229/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12740/10229/summary.html

[cvuosalo]

Would it be better to use getByToken() here?

[lgray]

This is necessary for the classes to operate in (py)FWLite and full CMSSW.
The consumes interface does not exist in edm::EventBase.

[cvuosalo]

An explanatory comment to that effect would be helpful here.

[lgray]

You cannot call consumes in FWLite and thus getbytoken cannot work. Likewise the accessor's are not available in edm::EventBase and cannot be used in this function.

[davidlange6]

@Dr15Jones - can we can this behavior?

[Dr15Jones]

@davidlange6 Are you asking if we can get rid of this behavior? That is you want us to invent a new mechanism in FWLite to allow equivalent consumes behavior?

[cvuosalo]

+1

For #12740 28bb2aa

Adding a new photon ID.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2015-12-09-1600 show no significant differences. Several other PRs were included by Jenkins in the tests, and they cause differences not related to this PR. An extended test of workflow 134.705_RunMET2015B with 200 events against baseline CMSSW_8_0_X_2015-12-10-1100 also shows no significant differences and no significant change in the size of event content for RECO or Mini-AOD.

[lgray]

@monttj @vadler Please review this PR.