make printNavType return std::string instead std::ostream #12755
Conversation
The way `printNavType` is used in `test/ModuleNumbering.cc` it attempts to put `std::ostream` into `std::ostream`, which is not allowed by C++11 or above. Refactor `printNavType` to return `std::string` instead and adjust related `operator<<`. Needed by GCC 5.3.0. Signed-off-by: David Abdurachmanov <[email protected]>
|
A new Pull Request was created by @davidlt for CMSSW_8_0_X. It involves the following packages: DetectorDescription/Core @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
Note, that tests are already running. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: e5cacfd ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
|
-1 Tested at: e5cacfd ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
make printNavType return std::string instead std::ostream
The way
printNavTypeis used intest/ModuleNumbering.ccit attemptsto put
std::ostreamintostd::ostream, which is not allowed byC++11 or above.
Refactor
printNavTypeto returnstd::stringinstead and adjustrelated
operator<<.Needed by GCC 5.3.0.
Signed-off-by: David Abdurachmanov [email protected]