-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made API to UnscheduledHander const #12811
Made API to UnscheduledHander const #12811
Conversation
Changed member functions which would be called from multiple threads simultaneously const in order to distinguish them from the members which are only going to be called serially. This should aid in checking for thread-safety. A needed followup will be to make Worker thread-safe.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
-1 Tested at: e7b0182 ---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Made API to UnscheduledHander const
Changed member functions which would be called from multiple threads simultaneously const in order to distinguish them from the members which are only going to be called serially. This should aid in checking for thread-safety.
A needed followup will be to make Worker thread-safe.