Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GTs for Run1 workflows to contain conditions for HcalQIETypes #12892

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 8, 2016

This PR complements #12832, to allow also the Run1 worfklow Global Tags to contain conditions for the new HcalQIETypes CondFormat.

List of Changes in Global Tag

RunI simulation

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10444/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

It involves the following packages:

Configuration/AlCa

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

davidlange6 added a commit that referenced this pull request Jan 9, 2016
Fixing GTs for Run1 workflows to contain conditions for HcalQIETypes
@davidlange6 davidlange6 merged commit 969b53f into cms-sw:CMSSW_8_0_X Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants