Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a pt<1 folder for HighPurity tracks in the DQM #12924

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jan 13, 2016

this PR is meant for adding a new set of plots for the tracks collection w/ pT < 1 GeV

those plots are needed in both the validation workflow and the offline certification
for the moment they are not added in the online set of plots

running whiteRabbit -n 11
I see that we are adding 92 new histos, which correspond to an increase of 0.139670 MB
w.r.t. the current setting we have in 80x

@VinInn @rovere @makortel @deguio @fiori

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

DQM/TrackingMonitorSource

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@VinInn
Copy link
Contributor

VinInn commented Jan 13, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10480/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jan 15, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@mtosi - i don't see where, but this PR appears to add the following printout to all events. Could you have a look. Thanks

Begin processing the 37th record. Run 191226, Event 557090291, LumiSection 398 at 13-Jan-2016 11:06:21.879 CET
bxlumi : 0.000000
totalNumPV : 15
totalNumGoodPV: 12
fracGoodPV: 0.800000
bxlumi : 0.000000

@cmsbuild
Copy link
Contributor

Pull request #12924 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@mtosi
Copy link
Contributor Author

mtosi commented Jan 18, 2016

I should have fixed this issue

hope this is fine

@VinInn
Copy link
Contributor

VinInn commented Jan 18, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10568/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jan 19, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 19, 2016
…llInDQM

adding a pt<1 folder for HighPurity tracks in the DQM
@cmsbuild cmsbuild merged commit 20ccf64 into cms-sw:CMSSW_8_0_X Jan 19, 2016
cmsbuild added a commit that referenced this pull request Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants