Fix signed muon tagger

[ghost]

Backport of #12937

Fix in the muon tagger signed discriminators, which were filled always and not only when the signed lepton selection was actually fulfilled.

[cmsbuild]

A new Pull Request was created by @imarches for CMSSW_7_6_X.

It involves the following packages:

RecoBTag/SoftLepton

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[slava77]

@imarches
Will the selector fail only if the sip sign is checked? There seem to be more parameters going into the selector. If this other logic in the selector is included in reco or miniAOD, then this PR is not good for 76X.
Please clarify.

[ghost]

@slava77

Yes, potentially other parameters may enter the selector but with the current set up we always return true here:

https://github.com/cms-btv-pog/cmssw/blob/FixSignedMuonTagger_from-CMSSW_7_6_3/RecoBTag/SoftLepton/src/LeptonSelector.cc#L38

so only the sign is effectively used.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10558/console

[cmsbuild]

+1
Tested at: 58019fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12956/10558/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12956/10558/summary.html

[cvuosalo]

+1

For #12956 58019fb

Small bug fix to stop the signed muon tagger from being filled unless a signed lepton was actually selected. #12937 is the 80X version of this PR, and it has already been merged.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2016-01-15-1100 show no significant differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1