Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New HcalCaloFlagLabels::HBHEOOTPU flag for RechitR45 filter #12974

Merged
merged 25 commits into from
Jan 20, 2016

Conversation

dertexaner
Copy link
Contributor

This adds a new HcalCaloFlagLabels::HBHEOOTPU flag for HBHE rechits to check the existence of an OOTPU pulse in BX-1 and BX+1 (only when the R45 value is about +/- 1).
The new flag is used together with HcalCaloFlagLabels::HBHETS4TS5Noise in calculating
HcalNoiseHPD::recHitEnergyFailR45 and HcalNoiseHPD::numRecHitsFailR45 quantities.
This PR targets 2016 data-taking, and aims to reduce the RechitR45 filter misID rate due to OOTPU in physics events, as presented at the HCAL DPG Meeting here:
https://indico.cern.ch/event/471297/contribution/3/attachments/1207313/1759753/Talk_Dec18_2015.pdf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dertexaner for CMSSW_8_0_X.

It involves the following packages:

DataFormats/METReco
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @argiro, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Jan 17, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10564/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 20, 2016

+1

for #12974 f2c47fa

  • code changes look OK
  • jenkins tests pass and comparisons with the baseline show no differences; apparently the tests are low enough statistics to not see the differences (slides linked suggest ~1E-3 rate, if it is per event, then lack of differences is expected)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 20, 2016
New HcalCaloFlagLabels::HBHEOOTPU flag for RechitR45 filter
@cmsbuild cmsbuild merged commit 62cd9ba into cms-sw:CMSSW_8_0_X Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants