Update to MVA MET: Fullfills "consumes" call requirement, Bugfix for the calculation of the covariance matrix, updated path to weight files #13086
Conversation
merge Mvamet76X updates to make PR to CMSSW_7_6_X
|
A new Pull Request was created by @rfriese (Raphael Friese) for CMSSW_7_6_X. It involves the following packages: RecoMET/METPUSubtraction @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -16,12 +16,13 @@ PFMETProducerMVA::PFMETProducerMVA(const edm::ParameterSet& cfg) | |||
| srcPFCandidatesView_ = consumes<reco::CandidateView>(cfg.getParameter<edm::InputTag>("srcPFCandidates")); | |||
| srcVertices_ = consumes<reco::VertexCollection>(cfg.getParameter<edm::InputTag>("srcVertices")); | |||
| vInputTag srcLeptonsTags = cfg.getParameter<vInputTag>("srcLeptons"); | |||
| edm::InputTag srcRho = ( cfg.exists("srcRho") ) ? cfg.getParameter<edm::InputTag>("srcRho") : (edm::InputTag("fixedGridRhoFastjetAll")); | |||
There was a problem hiding this comment.
ParameterSet::exists can be used only in exceptional cases.
Please define a fillDescriptions method if you need a default value
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideConfigurationValidationAndHelp
|
@rfriese |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #13086 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
| src = cms.InputTag('ak4PFJets'), | ||
| correctors = cms.vstring("ak4PFL1FastL2L3") # NOTE: use "ak5PFL1FastL2L3" for MC / "ak5PFL1FastL2L3Residual" for Data | ||
| correctors = cms.VInputTag("ak4PFL1FastL2L3Corrector") # NOTE: use "ak5PFL1FastL2L3" for MC / "ak5PFL1FastL2L3Residual" for Data |
There was a problem hiding this comment.
It looks like the comment should be updated. What are the correct tags for MC and data?
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #13086 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Update to MVA MET: Fullfills "consumes" call requirement, Bugfix for the calculation of the covariance matrix, updated path to weight files
Covariance matrix change: Was a bug not to use power of 2. See these plots done with the fix:
Without the fix the pulls are just way off.
All other things do not change the performance at all but are necessary to make the plugin work due to missing consumes calls before.