Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim : HLT SUSYBSM validation : remove dependence on non-existing collection 'conversions' #13237

Merged
merged 1 commit into from
Mar 1, 2016
Merged

FastSim : HLT SUSYBSM validation : remove dependence on non-existing collection 'conversions' #13237

merged 1 commit into from
Mar 1, 2016

Conversation

lveldere
Copy link
Contributor

gets rid of a whole list of warnings when running the validation sequence on FastSim

remove some obsolete configuration from SUSYBSM_HLT_VBF_Mu_cff.py

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11121/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

HLTriggerOffline/SUSYBSM

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

-1
Tested at: ddf8c14
I found an error when building:

>> Compiling python modules src/DQMServices/Core/python
>> Compiling python modules src/DQMServices/StreamerIO/python
>> All python modules compiled
>> Pluging of all type refreshed.
gmake[1]: Leaving directory `/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-09-1100'
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 1


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13237/11121/summary.html

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11140/console

@cmsbuild
Copy link
Contributor

-1
Tested at: ddf8c14
I found an error when building:

--- Registered EDM Plugin: HLTriggerOfflineSUSYBSM
>> Leaving Package HLTriggerOffline/SUSYBSM
>> Package HLTriggerOffline/SUSYBSM built
>> Subsystem HLTriggerOffline built
gmake: Target `all' not remade because of errors.
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13237/11140/summary.html

@deguio
Copy link
Contributor

deguio commented Feb 12, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11168/console

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11269/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

@deguio
tests finally ran properly, ready for review

@deguio
Copy link
Contributor

deguio commented Feb 22, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@lveldere
Copy link
Contributor Author

@davidlange6

would you mind merging this one in 80X?
Consider it a bug fix: it removes non-sensical warning messages when running physicsDQM on FastSim.
If not, I'll close this one, as it has no impact on production.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 1, 2016
…ions

FastSim : HLT SUSYBSM validation : remove dependence on non-existing collection 'conversions'
@cmsbuild cmsbuild merged commit dc44cd8 into cms-sw:CMSSW_8_0_X Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants