SIM/DIGI/RECO changes for HF QIE10 (part B) #13334
Conversation
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_0_X. It involves the following packages: CalibCalorimetry/HcalAlgos @civanch, @diguida, @cvuosalo, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @slava77, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Leaving library rule at TauAnalysis/MCEmbeddingTools
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-17-1400/src/SimCalorimetry/HcalSimProducers/src/HcalTestHitGenerator.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-17-1400/src/SimCalorimetry/HcalSimProducers/plugins/SealModule.cc
Copying tmp/slc6_amd64_gcc493/src/CondFormats/HcalObjects/test/testSerializationHcalObjects/testSerializationHcalObjects to productstore area:
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-17-1400/src/SimCalorimetry/HcalSimProducers/src/HcalDigitizer.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-17-1400/src/SimCalorimetry/HcalSimProducers/interface/HcalDigitizer.h:7:67: fatal error: SimCalorimetry/HcalSimAlgos/interface/HcalQIE10Traits.h: No such file or directory
#include "SimCalorimetry/HcalSimAlgos/interface/HcalQIE10Traits.h"
^
compilation terminated.
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-17-1400/src/SimCalorimetry/HcalSimProducers/interface/HcalDigiProducer.h:5:0,
from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-17-1400/src/SimCalorimetry/HcalSimProducers/src/HcalDigiProducer.cc:1:
you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
kpedro88
force-pushed
the
Phase1-HF4b
branch
from
15d5123 to
08676d6
Compare
|
Forgot to git add a few files, fixed now. Is this still targeted for 80X or should we move to the auto-generated #13344? |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
@kpedro88 - the 81x version of this PR does not merge. Could you have a look at it? |
|
@davidlange6 - the conflict is in Eras.py. I'm not sure of the correct procedure here - if I rebase this branch to the head of CMSSW_8_1_X, it will pollute the history of the 8_0_X PR. (If you merge this one first, then I can rebase and it will only affect the 8_1_X PR...) |
|
@civanch - can you also sign this one? |
|
+1 |
|
+1
|
|
+1 |
|
@davidlange6 - can this be merged? I'll address the merge conflict in #13344 afterward. |
|
@davidlange6 - I'm just going to keep pinging you... |
|
good - distracted with shorter term issues this week..
|
SIM/DIGI/RECO changes for HF QIE10 (part B)
This is the second part of #13232, which was split into 2 PRs. For the first part, see #13331.
@ggovi @franzoni - please continue the review here if you have further comments.
@civanch, your review would be appreciated also.
@slava77, this is identical to what you've already approved.
I rebased this branch up to the HEAD of the CMSSW_8_0_X branch, which includes #13331, so it should be ready to test.