-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cuts to SiStripMonitorTrack #13398
Add cuts to SiStripMonitorTrack #13398
Conversation
A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_0_X. It involves the following packages: DQM/SiStripMonitorTrack @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@schneiml the cut on Chi2 is reverted in your message, the right cut is Chi2/ndof < 10, probably is this that drops the number of hits by 99%, it is not expected to have this poor efficiency by those cuts. |
@fioriNTU I suspected that. It is this way round in the e-mail, but given that it goes to ∞ for ndof -> 0... |
Pull request #13398 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again. |
@fioriNTU Now the chi2 cut should be ok. We drop only around 60%. |
please test |
The tests are being triggered in jenkins. |
if final please submit to 81x as well. |
Pull request #13398 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again. |
After further commuication with Alessandro and Jean-Laurent, the cuts are now only applied to the per-cm histograms. Also, the numberOfValidTrackerHits cut was confirmed. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Add cuts to SiStripMonitorTrack
This commit introduces 4 cuts to select only good quality tracks for the track-based histograms of SiStripMonitorTrack:
These parameters were suggested by @dimattia and @jlagram, via @fioriNTU .
The cuts drop about 60% of all hits. They affect the track-based per-cm histograms in SiStripMonitorTrack. The off-track cluster based plots are unaffected.