bug fix: configured run range dependence was ignored in TkModuleGroupSelector. everything was associated to ... #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the information in which module group a det can be found. This information was unfortunately removed in a previous bug fix.
|
@demattia can you please review and eventually approve? @joergbehr Isn't this required also for CMSSW_7_0_X? |
ghost
assigned 
|
Hi Giulio, sorry for the stupid question, but I am just out of several overwhelming weeks and could not follow the recent changes in the procedures. Please, let me know, thanks, Marco Marco De Mattia On Aug 9, 2013, at 1:59 PM, Giulio Eulisse <[email protected]mailto:[email protected]> wrote: @demattiahttps://github.com/demattia can you please review and eventually approve? @joergbehrhttps://github.com/joergbehr Isn't this required also for CMSSW_7_0_X? — |
|
Ciao Marco. Please have a look at: http://cms-sw.github.io/cmssw/tutorial-l2-check-topics.html to have an idea of the process. We can sit together next week if you want. BTW, do you know what's roberto's github account? |
|
@ktf , yes it is required also for 7_0_X. Somehow I thought 6_2_X will be merged with 7_0_X at some point. Should I create a seperate pull request for 7_0_X or can this somehow be integrated into this one (I am rather new to git ...)? |
|
The following categories have been signed by @demattia: Calibration and Alignment @cms-git-alca |
|
@davidlt for next ORP. |
|
+1 |
ktf
added a commit
that referenced
this pull request
Sep 21, 2013
…duleGroupSelector AlCa bugfix: configured run range dependence was ignored in TkModuleGroupSelector.
nclopezo
added a commit
to nclopezo/cmssw
that referenced
this pull request
Nov 21, 2014
IB Pages: decide which IBs to show by reading config.map
gdimperi
pushed a commit
to gdimperi/cmssw
that referenced
this pull request
Jun 21, 2015
Nuisance modification syntax
mariadalfonso
added a commit
to mariadalfonso/cmssw
that referenced
this pull request
May 6, 2017
New variables and fixed ntuples
jbsauvan
added a commit
to jbsauvan/cmssw
that referenced
this pull request
Aug 31, 2017
Backport PR comments
kurtejung
added a commit
to kurtejung/cmssw
that referenced
this pull request
Oct 9, 2017
Make jet sequences work for reco with 92X and 93X
fwyzard
added a commit
to makortel/cmssw
that referenced
this pull request
Aug 17, 2018
Clean up unnecessary changes, whitespaces, defines and include directives.
Closed
slava77
pushed a commit
to slava77/cmssw
that referenced
this pull request
Oct 9, 2021
Skylake platform, gcc with CMSSW flags, performance improvements & bug fixes
yulunmiao
pushed a commit
to yulunmiao/cmssw
that referenced
this pull request
Oct 9, 2024
Code format HGCalMappingESSourceTester.cc Removing unused includes and delarations after PR comments Correction: missing :: for namespace Fix code style indentation record descriptions Re-introducing headers.h file needed for serialization classes remove data and change locations to cms-data folder moving to single record as all conds produced have the same IOV re-introducing 1 record per payload, addressing additional code comments moving to printf, removing unused product, and message logger code checks remove unused iomanip adding digi SoAs update collection names moving emulators to SimCalorimetry/HGCalSimAlgos, adapting paths moving digi soa filler to alpaka and adding extra tools some progress with soafiller updating fixing but in module es producer (assignment of capture block index instead of capture block) add dense index map for HGCalElectronicsId add getMaxDataSize & getMaxERxSize functions fix getDenseIndex bug; add typcode map to ModuleIndexer (to retrieve module dense index offset); use regexp for type code add getFedAndModuleIndex; rename getDenseIndex -> getIndexForModule(Data) for elecID add calibrations Alpaka ESProducer rename ES_HGCal*Parameter.cc -> HGCal*ParameterHostCollection.cc for clarity int -> uint32_t; uncomment debugging print out clean add HGCal configuration ESProducers + record + tester rename ES_HGCal*Parameter.cc -> HGCal*ParameterHostCollection.cc for clarity rename HGCal*ParameterHostCollection.cc -> HGCal*ParameterDeviceCollection.cc for clarity rename 'HGCal.*(Device|Host)Collection -> (Device|Host)' for readability; move calib SoAs to CondFormats/HGCalObjects/; move TestHGCalRecHitESProducers to test rename 'HGCal.*(Device|Host)Collection -> HGCal.*(Device|Host)' for readability add HGCalRecHit add DIGI2RECO calibration algorithms (see https://gitlab.cern.ch/hgcal-dpg/hgcal-comm/-/merge_requests/3)[C; remove detId/elecId from SoAs (should be redundant since common indexer); add HGCROCChannelDataFrame<HGCalDetId> to classes_def.xml Move HGCalRawDataDefinitions.h. [WIP] Refactor unpacker. parse arrays of gain-dependent calibration parameters in eRx-blocks add missing Noise attribute updating usage of Rcd fixing cfg files Convert ECON-D payload to 32b words. [Unpacker] rebase the unpacker on denseIdx and SoA digis Update unpacker code. SoA format of HGCal ECON-D header Unpack header information to HGCalECONDInfoSoA; Add in quality checks for ECON-D remove unused add typecode regexp; pass typecode to modIndexer_.processNewModule update ESProducers update record fix ESInputTags prefix filename with T_EventSetup_ add HGCalConfiguration & HGCalConfigurationESProducer Update and rename HGCalRecHitProducer.cc to HGCalRecHitProducers.cc fill HGCal config structs for unpacker (header marks, charMode) update calibration kernels read HGCal FED & ECON-D configuration from JSON Update unpacker to use HGCalConfiguration structure make manual overrides truly optional fix compilation issue due to initialization of const gain Change to LogDebug adding dense index info producer adding hgcalmapping customise fix misunderstanding in max data size expected from indexer Implement TH2Poly in DQM based on 14e856f Update HGCalConfigurationESProducer.cc update unpacker and HGCalConfiguration Add definitions of flags in digi SOA update the other part to most recent commit Add flags for passthrough ECON-Ds Debug: loop through every denseIdx Fix the number of channel in eRx;Add default flag for digi, representing digi not read in raw data fully read config parameters from JSONs for config SoA; add sanity checks; add HGCalMappingModuleIndexer::getNFED; rename getFedAndModuleIndex -> getIndexForFedAndModule; clean code; ... rename macro silence debugging message in ESProducers silence cout add HGCalMappingModuleIndexer::getMaxModuleSize(fedid) typo; SystemTestEventFilters/data -> Configuration/data bugfix in the cm Sum fixing dense index issue Update comment in HGCalMappingParameterSoA.h Some additional fixes (cms-sw#132) - remove_if was missing a call to std::vector::erase to effectively remove unused entries - typecodemap was missing a reset with the final indices - usage of command line options was missing in module map tester - do not use moduleLUT in DenseIndexInfoESProducer!! it has the full dimensions before trimming to the actual number of ECON-Ds in a FED Add parsing function for econd flag; renaming HGCalECONDInfo to HGCalECONDPacketInfo Add irot to module mapper (cms-sw#134) * - remove_if was missing a call to std::vector::erase to effectively remove unused entries - typecodemap was missing a reset with the final indices - usage of command line options was missing in module map tester * do not use moduleLUT in DenseIndexInfoESProducer!! * Adding optional irot to module mapper file - If existing it will be put in the module info SoA - othwerwise a default irot=0 (baseline is used) Suppress "unused variable" warning: remove CellIndexer in HGCalDigiSoaFiller.cc apply code formats (cms-sw#135) Apply suggestions from code review Apply easy suggestions by Matti. (Looking into other comment & suggestions.) Co-authored-by: Matti Kortelainen <[email protected]> 'const json' to fix compilation issue for Matti's suggestion gain index should be taken as is, not subtracted by 1 make use of valid at rechit level / set rechit valids fill rec hitflags update kernel after closure Implement suggestions for CMSSW_14_1_X PR cms-sw#45665 (cms-sw#137) * Implement TH2Poly in DQM Services for HGCal DQM * Apply changes from code quality checks * Add a patch based on makortel's comments * enum -> namespace + constexpr uint{8,16,32}_t * Matti suggestion: remove '_t' postfix from HGCalFEDReadoutSequence_t, HGCalROCConfig_t, HGCalECONDConfig_t, HGCalFedConfig_t structs * Matti suggestions & code checks: remove redundant comments; silence debugging cout or use MessageLogger; move includes; remove trailing '_' from function arguments * Matti suggestion: reuse typecodeMap_.find() to avoid searching twice (TODO: throw exception if not found?) * Matti suggestion: use SET_PORTABLEHOSTCOLLECTION_READ_RULES; add ClassVersion+checksum * Matti suggestion: iRecord.getRecord<...>. -> iRecord. * Matti suggestion: iRecord.getRecord<...>. -> iRecord.; rm redundant includes & couts; pass reference to fill_SoA_column to avoid copy * Matti suggestions: use SET_PORTABLEHOSTCOLLECTION_READ_RULES for HGCalRecHitHost; Remove deprecated HGCalFlaggedECONDInfo* & comments; * Matti suggestion: throw exception if type code not found; replace for-loop with std::accumulate * Matti suggestion: remove TestObjects * Matti suggestions: remove config as member data and produce unique_ptr instead of shared_ptr; NULL → nullptr; initialize optional override; memcp -> std::copy * Matti suggestions: use file in path * removing soafiller and updating buildfile (cms-sw#139) * address comments on HGCalRecHitCalibrationAlgorithms.dev.cc * irot as uint8_t instead of char * restore DQM without TH2Poly * apply code formats --------- Co-authored-by: ywkao <[email protected]> Co-authored-by: Pedro <[email protected]> restore release base DQM classes (cms-sw#140) move to chrono calls instead of struct inside namespace (cms-sw#141) address comments (cms-sw#142) update include (cms-sw#143) remove ECON-D tests as they'll need to be re-written in a different form (cms-sw#144) Declare HGCalRecHitCalibrationAlgorithms::calibrate as const method (cms-sw#145) * remove ECON-D tests as they'll need to be re-written in a different form * enable const patching unpacker for padding of capture blocks within FED move check of padding to start of capture block Fix the throw, so the processing won't stop at the first event with error Update HGCalRecHitCalibrationAlgorithms.dev.cc CM sum -> 0.5*CM sum Change the throws to specific returns Optimize the producer Debugging the padding of eRx subpackets roll back (cms-sw#149) apply code checks and remove dqm
cmsbuild
pushed a commit
that referenced
this pull request
Jan 17, 2025
The following is a squashed commit of the contributions of different people Co-authored-by: IzaakWN <[email protected]> Co-authored-by: Lovisa <[email protected]> Co-authored-by: Matti Kortelainen <[email protected]> Co-authored-by: Pedro Silva <[email protected]> Co-authored-by: Yulun Miao <[email protected]> Co-authored-by: ineuteli <[email protected]> Co-authored-by: ywkao <[email protected]> A summary of contents follows. Note this has been edited (ammended by @pfs): - HGCal Electronics Mapping for alpaka (#161) - add dense index map for HGCalElectronicsId - add getMaxDataSize & getMaxERxSize functions - fix getDenseIndex bug; add typcode map to ModuleIndexer (to retrieve module dense index offset); use regexp for type code - add getFedAndModuleIndex; rename getDenseIndex -> getIndexForModule(Data) for elecID - add typecode regexp; pass typecode to modIndexer_.processNewModule - adding dense index info producer - adding hgcalmapping customise - fix misunderstanding in max data size expected from indexer - remove_if was missing a call to std::vector::erase to effectively remove unused entries - typecodemap was missing a reset with the final indices - usage of command line options was missing in module map tester - do not use moduleLUT in DenseIndexInfoESProducer!! it has the full dimensions before trimming to the actual number of ECON-Ds in a FED - Add irot to module mapper (#134) - move variables to private, use getters and move bulky code to .cc in HGCalMappingModuleIndexer / apply code checks - CondFormats - add calibrations Alpaka ESProducer - rename ES_HGCal*Parameter.cc -> HGCal*ParameterHostCollection.cc for clarity - moving to single record as all conds produced have the same IOV - add HGCal configuration ESProducers + record + tester - Record descriptions added - Re-introducing 1 record per payload, addressing additional code comments - rename ES_HGCal*Parameter.cc -> HGCal*ParameterHostCollection.cc for clarity - rename HGCal*ParameterHostCollection.cc -> HGCal*ParameterDeviceCollection.cc for clarity - rename 'HGCal.*(Device|Host)Collection -> (Device|Host)' for readability; move calib SoAs to CondFormats/HGCalObjects/; move TestHGCalRecHitESProducers to test - fill HGCal config structs for unpacker (header marks, charMode) - read HGCal FED & ECON-D configuration from JSON - Adding digi SoAs - moving digi soa filler to alpaka and adding extra tools - rename 'HGCal.*(Device|Host)Collection -> HGCal.*(Device|Host)' for readability - Refactor unpacker. - parse arrays of gain-dependent calibration parameters in eRx-blocks (simplified in latter commits to remove explicit gain-dependence) - add missing Noise attribute - Convert ECON-D payload to 32b words. - rebase the unpacker on denseIdx and SoA digis - Moving emulators to SimCalorimetry/HGCalSimAlgos, adapting paths - fix undefined left shift in HGCalRawDataPackingTools.cc; remove duplicate line in HGCalMappingTools.h (32 -> 31 to solve undefined left shift) - SoA format of HGCal ECON-D header - Unpack header information to HGCalECONDInfoSoA; Add in quality checks for ECON-D - Update unpacker to use HGCalConfiguration structure - Add flags for passthrough ECON-Ds - Fix the number of channel in eRx;Add default flag for digi, representing digi not read in raw data - Add parsing function for econd flag; renaming HGCalECONDInfo to HGCalECONDPacketInfo - Add in common mode in ECOND packet information - enable FED-level Parallelization through config - Remove change of location when something wrong in S-Link trailer - Add HGCalRecHit - add DIGI2RECO calibration algorithms (see https://gitlab.cern.ch/hgcal-dpg/hgcal-comm/-/merge_requests/3)[C; remove detId/elecId from SoAs (should be redundant since common indexer); add HGCROCChannelDataFrame<HGCalDetId> to classes_def.xml - Move HGCalRawDataDefinitions.h. - Update and rename HGCalRecHitProducer.cc to HGCalRecHitProducers.cc - update calibration kernels - bugfix in the cm Sum - fill rec hitflags - update kernel after closure - swap arguments in tot kernel - Code formats / checks - Removing unused includes and delarations - Re-introducing headers.h file needed for serialization classes - Remove data and change locations to cms-data folder - moving to printf, removing unused product, and message logger - int -> uint32_t; uncomment debugging print out - Change to LogDebug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...the first IOV.