-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StoNCorrOnTrack in modules with the highest values #13413
StoNCorrOnTrack in modules with the highest values #13413
Conversation
A new Pull Request was created by @rrabadan (Raul Rabadan) for CMSSW_8_0_X. It involves the following packages: DQM/SiStripMonitorClient @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
please submit to 80x as well |
The tests are being triggered in jenkins. |
sign please |
ciao @rrabadan |
PR for 81X: 13560 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
…alues StoNCorrOnTrack in modules with the highest values
@@ -112,9 +112,9 @@ | |||
cms.PSet(mapName=cms.untracked.string('NumberOfOfffTrackCluster'),TopModules=cms.untracked.bool(True)), | |||
cms.PSet(mapName=cms.untracked.string('NumberOfOfffTrackCluster'),mapSuffix=cms.untracked.string("_autoscale"),mapMax=cms.untracked.double(-1.)), | |||
cms.PSet(mapName=cms.untracked.string('NumberOfOnTrackCluster')), | |||
cms.PSet(mapName=cms.untracked.string('StoNCorrOnTrack')), | |||
cms.PSet(mapName=cms.untracked.string('StoNCorrOnTrack',TopModules=cms.untracked.bool(True)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto merge job (80X changes in to 81X) failed to resolve the above? Is not there a missing ')' after 'StoNCorrOnTrack'? In 81X we have 0249733#diff-da712dd5a8dd05d67efa0e78be33b175
modules that have a S/N corrected by track angle less than 10 added in list of modules with highest values