Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLTTauRefProducer: bugfix #13426

Merged
merged 2 commits into from
Mar 2, 2016

Conversation

slehti
Copy link
Contributor

@slehti slehti commented Feb 22, 2016

HLTTauRefProducer: fixed selection of reference taus with nonexistent discriminators

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slehti for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slehti
Copy link
Contributor Author

slehti commented Feb 24, 2016

Pushed a commit containing update on the reference tau selection to the HLTTauRefProducer_BugFix_80X branch.

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

please test

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11631/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

@davidlange6
Copy link
Contributor

@slehti @deguio - is there a quick way to motivate this change of behavior?

@slehti
Copy link
Contributor Author

slehti commented Mar 2, 2016

The intended change of behavior: if there is something wrong with the offline tau selection, like an obsolete discriminator being used, no offline tau is found and the DQM plots are empty.

@davidlange6
Copy link
Contributor

+1
Thanks!

cmsbuild added a commit that referenced this pull request Mar 2, 2016
@cmsbuild cmsbuild merged commit a409238 into cms-sw:CMSSW_8_1_X Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants