Testing OutputModules only get products they consume #13467
Conversation
ProvenanceCheckerOutputModule and GetProductCheckerOutputModule now only get the data products specified in their configuration rather than everything in the Principal. This is a step towards removing the Principal::getForOutput option which avoids getting the product. That option would cause problems for multiple threads used for one event.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/Modules @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
@wmtan here is the change I said I was going to make today |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: 5ab648f ---> test runtestTqafTopEventSelection had ERRORS you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
The test failure is not from this pull request |
|
This failure is not from this pull request and comes from the IB. |
Testing OutputModules only get products they consume
ProvenanceCheckerOutputModule and GetProductCheckerOutputModule now only get the data products specified in their configuration rather than everything in the Principal.
This is a step towards removing the Principal::getForOutput option which avoids getting the product. That option would cause problems for multiple threads used for one event.