-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve print_trace in DQMStore #13475
Conversation
A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X. It involves the following packages: DQMServices/Core @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Improve print_trace in DQMStore
The DQMStore supports logging the caller for all booking calls, which can be very useful to understand what the DQM codebase is doing.
This PR improves this functionality by searching for the first “interesting” caller in the stack trace. The previous implementation sometimes reported helpers within the DQMStore, or functions with missing debug symbols that could not be printed. With these improvements, it gives a meaningful attribution for all histogram bookings.