-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory leaks in EcalClusterLazyTools #13504
Conversation
A new Pull Request was created by @jolange (Johannes Lange) for CMSSW_8_0_X. It involves the following packages: RecoEcal/EgammaCoreTools @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Pull request #13504 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Pull request #13504 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Fixing a memory leak in EcalClusterLazyToolsBase. There should be no change in monitored quantities. #13497 and #13505 are the 76X and 81X versions of this PR, and the former has already been approved. The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-03-06-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
fix memory leaks in EcalClusterLazyTools
see #13497