Improve exception message for missing produces call #13521
Conversation
The previous exception message given when a module was missing a produces call printed the entire contents of the ProductRegistry. The new message only prints those entries which the module has registered and gives two ways to potentially fix the problem.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 DAS Error 1000.0 step1 DAS Error you can see the results of the tests here: |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log ----- Begin Fatal Exception 29-Feb-2016 18:29:43 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log ----- Begin Fatal Exception 29-Feb-2016 18:43:52 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 134.911 step1 DAS Error you can see the results of the tests here: |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
Improve exception message for missing produces call
The previous exception message given when a module was missing a produces call printed the entire contents of the ProductRegistry. The new message only prints those entries which the module has registered and gives two ways to potentially fix the problem.