bsunanda:Run2-hcx71 Try to sort out some geometry issue of HGCal #13522
Conversation
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
| if (ntf > 0) { xmf /= ntf; ymf /= ntf;} | ||
| if (ntc > 0) { xmc /= ntc; ymc /= ntc;} | ||
| std::cout << "Fine " << ntf << " x " << xmf << " y " << ymf << std::endl; | ||
| std::cout << "Coarse " << ntc << " x " << xmc << " y " << ymc << std::endl; |
|
Pull request #13522 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
The tests are being triggered in jenkins. |
|
@bsunanda Thanks! |
|
-1 DAS Error you can see the results of the tests here: |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
geometry-approved
fully-signed
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
bsunanda:Run2-hcx71 Try to sort out some geometry issue of HGCal
This is to address wrong indexing for finer wafer