Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT DQM fixes for PoA #13523

Closed
wants to merge 17 commits into from
Closed

Conversation

jfernan2
Copy link
Contributor

Needs to follow PR #13399

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for CMSSW_8_0_X.

It involves the following packages:

CalibTracker/SiStripCommon
DPGAnalysis/Skims
DQM/DTMonitorClient
DQM/DTMonitorModule
DQM/HcalCommon
DQM/HcalTasks
DQM/Integration
DQM/TrigXMonitor
DQMOffline/Configuration
EventFilter/L1GlobalTriggerRawToDigi
L1Trigger/L1TGlobal

@diguida, @boudoul, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @deguio, @mmusich, @vanbesien, @hengne, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@batinkov, @gbenelli, @tocheng, @Martin-Grunewald, @jlagram, @threus, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

ciao @jfernan2
this PR removes >100 files. is this what you meant to do? could you please elaborate more on the goal of this PR?
moreover it would be nice to test this PR in 81x first. please submit new developments there.
thanks,
F.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Mar 1, 2016

ciao @deguio , I'm sorry, I only meant to change code on DQM/DTMonitorModule package, I understand now that this PR involves other packages so I should have submitted them untouched...
My apologies.
The code is necessary for DT Prompt Offline Package to work properly. Should I then push it in 81X as an new independent PR? I'm sorry for the incovenience. Thanks

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

ciao @jfernan2
I see O(100) files removed in the DQM/DTMonitorClient. could you elaborate on what you want to do with this PR? I will look into more details since the change is too big to be visualized in github.
thanks,
F.

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

and yes. you need to push an independent PR to 81x.
thanks,
F.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Mar 1, 2016

Hi, deletion of files in DQM/DTMonitorClient were by accident, please ignore this PR, I'm sorry for the incovenience. I have create a new PR in 81X with only the changes for DQM/DTMonitorModule
#13539
Thanks

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

-1
sounds good.
thanks,
F.

@mmusich
Copy link
Contributor

mmusich commented Mar 2, 2016

-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants