PSet.clone now works like module clone #13526
Conversation
The PSet.clone method now calls the same function used by module clone to handle the parameters. This now allows removal of parameters and the use of a dict to modify parameters of sub PSets.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 DAS Error 1001.0 step1 DAS Error you can see the results of the tests here: |
|
Thanks Chris. |
…lone PSet.clone now works like module clone
|
Comparison is ready The workflows 1001.0, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
The PSet.clone method now calls the same function used by module clone to handle the parameters. This now allows removal of parameters and the use of a dict to modify parameters of sub PSets.