-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications to guns to allow finite decay length for mothers #13527
Conversation
A new Pull Request was created by @smrenna (Stephen Mrenna) for CMSSW_8_1_X. It involves the following packages: GeneratorInterface/Pythia8Interface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Modifications to guns to allow finite decay length for mothers
(fMasterGen->event).append( particleID, 1, 0, 0, -px, -py, -pz, ee, mass ); | ||
int eventSize = (fMasterGen->event).size()-1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the closing brace is misplaced here.
Compare to EGun.
Here we end up with tau set only if "-particleID" is not a particle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a proposed fix in #16743
No description provided.