Do not use constexpr with std::log in C++14 for ICC #13658
Conversation
C++14 standard prohibits library implementation to mark random C++ standard library functions as being `constexpr`. That's why this isn't working with Clang and ICC in general. It's a bit of gray area here. GCC most likely will lower `std::log` to `__builtin_log_*` intrinsic which are not covered by C++14 standard. Thus it's `__builtin_log_*` which is `constexpr`, thus making it work under C++14. Signed-off-by: David Abdurachmanov <[email protected]>
|
A new Pull Request was created by @davidlt for CMSSW_8_1_X. It involves the following packages: TrackingTools/GsfTracking @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Do not use constexpr with std::log in C++14 for ICC
C++14 standard prohibits library implementation to mark random C++
standard library functions as being
constexpr. That's why this isn'tworking with Clang and ICC in general.
It's a bit of gray area here. GCC most likely will lower
std::logto__builtin_log_*intrinsic which are not covered by C++14 standard.Thus it's
__builtin_log_*which isconstexpr, thus making it workunder C++14.
Signed-off-by: David Abdurachmanov [email protected]