-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-IOV weak mode constraints (Backport of #13710) #13711
Multi-IOV weak mode constraints (Backport of #13710) #13711
Conversation
Introduced some C++11 features to streamline the code.
- Create constraint configurations for each IOV. - technically working: compiling and pede does not complain -> Need to verify that the result looks as expected - empty IOVs are problematic because the associated parameters are removed by pede's cut on the number of hits (since there are 0 hits) -> either ignore IOVs by providing a list of IOVs or use pede option 'skipemptycons' (preferred)
- default (next level) behaviour can be changed now - added configuration flag to apply constraint at lowest level
A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_0_X. It involves the following packages: Alignment/CommonAlignment @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
…ts_80X Multi-IOV weak mode constraints (Backport of #13710)
Feature allows to constrain the tracker alignment procedure to avoid the introduction of weak modes.
Includes extension of the existing code to support multi-IOV alignments + clean-up of existing code.
Presented at Tracker Alignment meeting 16 March 2016:
https://indico.cern.ch/event/504824/session/0/contribution/65/attachments/1244395/1831868/talk.pdf
Backport of #13710