Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

80x Fireworks: Port change in FWSiPixelClusterPB from 71 #13741

Merged
merged 3 commits into from
Mar 17, 2016
Merged

80x Fireworks: Port change in FWSiPixelClusterPB from 71 #13741

merged 3 commits into from
Mar 17, 2016

Conversation

alja
Copy link
Contributor

@alja alja commented Mar 16, 2016

This are commits which have been overriden by accident. This involves change from 71 in PR #4681.

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Mar 16, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_8_0_X.

It involves the following packages:

Fireworks/ParticleFlow
Fireworks/Tracks

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@alja alja changed the title 80x Fireworks: Port change in FWSIPixelClusterPB from 71 80x Fireworks: Port change in FWSiPixelClusterPB from 71 Mar 16, 2016
@alja alja mentioned this pull request Mar 16, 2016
Closed
@alja
Copy link
Contributor Author

alja commented Mar 16, 2016

@arizzi first noticed this problem.

@alja
Copy link
Contributor Author

alja commented Mar 16, 2016

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11932/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

+1
Tested at: 16b176f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13741/11932/summary.html

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 17, 2016
@cmsbuild
Merge pull request #13741 from alja/from-CMSSW_8_0_2
bceed6c 
80x Fireworks: Port change in FWSiPixelClusterPB from 71
@cmsbuild cmsbuild merged commit bceed6c into cms-sw:CMSSW_8_0_X Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed orp-approved tests-approved visualization-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
3 participants
@alja @cmsbuild @davidlange6