-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix in the BoostedDoubleSV tagger (81X) #13749
Bugfix in the BoostedDoubleSV tagger (81X) #13749
Conversation
A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_1_X. It involves the following packages: RecoBTag/SecondaryVertex @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Small bug fix for the BoostedDoubleSV tagger. There should be no change in monitored quantities. #13751 is the 80X version of this PR, and it has already been approved. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-03-17-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
…-CMSSW_8_1_0_pre1 Bugfix in the BoostedDoubleSV tagger (81X)
Bugfix for the BoostedDoubleSV tagger. The bug is expected to manifest itself in extremely rare instances where a jet has only one constituent. The fix has no impact on RECO (since the tagger is not run there) but could impact MiniAOD in those rare instances.