Phase2 full reco workflow #14865
Phase2 full reco workflow #14865
Conversation
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/HcalPlugins @ghellwig, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @rekovic, @srimanob, @cerminar, @franzoni, @slava77, @mmusich, @hengne, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
| if k2 in PUDataSets: | ||
| upgradeStepDict['RecoFullGlobalPU'][k]=merge([PUDataSets[k2],upgradeStepDict['RecoFullGlobal'][k]]) | ||
|
|
||
| upgradeStepDict['RecoFullGlobal_trackingOnlyVal'][k] = {'-s':'RAW2DIGI,L1Reco,RECO,VALIDATION:@trackingOnlyValidation,DQM:@trackingOnlyDQM', |
There was a problem hiding this comment.
@kpedro88 An alternative would be to use the standard VALIDATION and DQM sequences, and configure them to contain only the tracking validation and DQM (respectively) with eras (unless this is not just temporary). That was the approach I used for phase1.
There was a problem hiding this comment.
@kpedro88 Sure, if it is indeed very temporary. But I'd guess that at some point phase2 will need VALIDATION+DQM beyond tracking-only, and the modules in the sequences probably need to be enabled in steps (as happened with phase1, and in fact there are still modules disabled).
There was a problem hiding this comment.
I think we should address this in a subsequent PR. I am still discussing with other experts which subdetectors might be ready for Phase2 validation/DQM.
There was a problem hiding this comment.
I'm curious what would you name this once more than trackingOnly is added to the validation (e.g. trackingAndJetAndBlahAndBlah and so on)?
It may be better to have a common name
There was a problem hiding this comment.
I don't know what I'll name it. Maybe phase2Val? This section of relval_steps.py is commented as "UPGRADE WORKFLOWS IN PREPARATION" for a reason. It is not always clear what the path forward will be for the upgrade development. Some allowances need to be made.
There was a problem hiding this comment.
I find it to be an easier allowance to keep one name and not generate more and more specifically named implementations.
There was a problem hiding this comment.
there are several minor annoyances that come with this further extended naming:
- the step key is used in the directory name generated by runTheMatrix. So, it's getting longer and longer and begins to wrap around in my ls
- I use full directory names to map inputs for jenkins comparisons. If the directory name changes, we loose a possibility to compare content.
|
+1 |
cmsbuild
added
geometry-approved
and removed
geometry-pending
comparison-available
geometry-approved
tests-approved
labels
cmsbuild
added
tests-approved
comparison-pending
and removed
comparison-available
tests-started
labels
|
@davidlange6 what is the timeline for pre8? This still needs signatures from @civanch, @ianna, @mmusich, @hengne, @dmitrijus, @mulhearn. Hopefully there will not be any further commits needed. |
|
+1 |
|
+1 |
cmsbuild
added
alca-approved
operations-approved
and removed
alca-pending
operations-pending
labels
|
+1 |
This PR updates the Phase2 GReco workflow to do the full RECO step (no longer just tracking reco). List of changes:
Tested by running upgrade workflows 11200 and 10600.
Comments welcome...
attn: @ebrondol, @boudoul, @VinInn, @ianna, @bsunanda, @lgray, @calabria