-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set siPixelClusters.MissCalibrate=True for phase1 #15563
Conversation
Needed since the sim digitizer has MissCalibrate set to True.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: RecoLocalTracker/SiPixelClusterizer @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild , please test |
The tests are being triggered in jenkins. |
@makortel |
@slava77 Here are MTV plots for 1000 QCD 3000-3500 TeV events https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_8_1_0_pre10_phase1MissCalibrate_qcd/ |
+1 for #15563 6516332
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
The (sim) pixel digitizer
MissCalibrate
parameter was set toTrue
in #13357, so thesiPixelClusters.MissCalibrate
needs to be set toTrue
as well.Tested in 8_1_0_pre10, small changes (numerical-level on tracking) expected in phase1 workflows (no changes expected for phase0/2). Here are MTV plots for 1000 TTbar noPU events https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_8_1_0_pre10_phase1MissCalibrate/.
Another PR switching the 2017 workflow to "digi->raw->digi" chain for pixels will follow once this gets merged.
@rovere @VinInn @dkotlins @veszpv