Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set siPixelClusters.MissCalibrate=True for phase1 #15563

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

makortel
Copy link
Contributor

The (sim) pixel digitizer MissCalibrate parameter was set to True in #13357, so the siPixelClusters.MissCalibrate needs to be set to True as well.

Tested in 8_1_0_pre10, small changes (numerical-level on tracking) expected in phase1 workflows (no changes expected for phase0/2). Here are MTV plots for 1000 TTbar noPU events https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_8_1_0_pre10_phase1MissCalibrate/.

Another PR switching the 2017 workflow to "digi->raw->digi" chain for pixels will follow once this gets merged.

@rovere @VinInn @dkotlins @veszpv

Needed since the sim digitizer has MissCalibrate set to True.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalTracker/SiPixelClusterizer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @gpetruc, @threus this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor

VinInn commented Aug 23, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14670/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2016

@makortel
it looks like the high-pt end is affected the most
please add some MTV plots with high-pt dijets or muon guns

@makortel
Copy link
Contributor Author

@slava77
Copy link
Contributor

slava77 commented Aug 29, 2016

+1

for #15563 6516332

  • change in the configuration is as described, moving towards more realistic setup of phase1 pixel treatment
  • jenkins tests pass and comparisons with baseline show changes only in 2017 workflows with fairly small differences. Higher stat test results with MTV plots provided by @makortel show small changes.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ba7bdf3 into cms-sw:CMSSW_8_1_X Aug 29, 2016
@makortel makortel deleted the fixPhase1MissCalibrate branch February 12, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants