Fix PackedCandidate::dz and PhotonIDValueMapProducer

[gpetruc]

• fix the dz(point) method of PackedCandidate to work correctly when point is not the associated PV, and the eta of the candidate is not the eta of the track. This ensures that cand.dz(point) is always the same as cand.track.dz(point) whenever the track is available (as it was already the case for dxy)
• fix the PhotonIDValueMapProducer on miniAOD to get the dxy and dz from the candidate instead of the track (dxy and dy are always available in the candidate, but they're not available in the track at low pT, and in 94X this causes an exception)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20491/666

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

DataFormats/PatCandidates
RecoEgamma/PhotonIdentification

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray, @gouskos, @jainshilpi, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

@arizzi @emanueledimarco @peruzzim : this is needed to get the nanoAOD prototype running in 94X

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22939/console Started: 2017/09/13 11:38

[cmsbuild]

+1
Tested at: 852157f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20491/22939/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8dd9a2c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20491/22939/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20491/22939/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20491/22939/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2646524
• DQMHistoTests: Total failures: 209
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2646126
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[perrotta]

@gpetruc : should I expect any difference in the miniAOD output with this fix? I am not able to see any...

[gpetruc]

PhotonIDValueMapProducer should be transparent. dz should give tiny differences in rare cases but maybe the bugged version was not used anywhere in production. Il 20 Set 2017 10:40, "perrotta" <[email protected]> ha scritto: @gpetruc <https://github.com/gpetruc> : should I expect any difference in the miniAOD output with this fix? I am not able to see any... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20491 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEbbRxpIVrbs8u-tyjsTUIqDkLpzrARiks5skM91gaJpZM4PVvie> .

[perrotta]

+1

• Fix for rare cases (no effect visible in jenkins or small size private tests)
• Code changes are in line with what in the description

[davidlange6]

merge