-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NanoAOD update 10XY version (master version of #23445) #23446
NanoAOD update 10XY version (master version of #23445) #23446
Conversation
…le to add these to the nanoAOD event trees
…sent in 92X and beyond)
My suspicion is that the ternary operator (??:) cannot be inlined; it gave completely bogus results. Fortunately, correct trigger bits were recovered with max() function, which serves as logical OR operator in this context.
…WPTight), 4 = 1e (WPLoose)
… same pattern as Muon
…w/o b-tag SF .csv files, updated BuildFile
…ltiple discriminators, added separate measType configs for B/C/UDSG, patched minor cmssw incompatibility
…s are unavailable
…from MG26X systematics module
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23446/5429 |
The tests are being triggered in jenkins. |
+1 |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
see more notes in #23446 (comment) Based on the earlier discussion (#23446 (comment)), more changes will be necessary before the nanoAOD is ready for reprocessing the upcoming 80XLegacy reminiAOD |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR is the equivalent of
cms-nanoAOD#175
but with stripped out data files that should be included via:
cms-sw/cmsdist#4077
Features:
Soft Activity bug fix, wrong input tag used
Fixing GenWeightsTable producer for MG26X samples
Updating triggerObjects_cff.py to include physics based HLT trigger filter bit scheme
80X MET Filters - bad muon flags
Added b-tag SF EDProducer to get event weights
New b-jet energy regression
run deepCSV on the fly for 80X input
same as #23445
@gpetruc