Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoAOD update 10XY version (master version of #23445) #23446

Merged
merged 59 commits into from
Jul 9, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jun 4, 2018

This PR is the equivalent of
cms-nanoAOD#175
but with stripped out data files that should be included via:
cms-sw/cmsdist#4077

Features:

Soft Activity bug fix, wrong input tag used
Fixing GenWeightsTable producer for MG26X samples
Updating triggerObjects_cff.py to include physics based HLT trigger filter bit scheme
80X MET Filters - bad muon flags
Added b-tag SF EDProducer to get event weights
New b-jet energy regression
run deepCSV on the fly for 80X input

same as #23445

@gpetruc

arizzi and others added 30 commits June 4, 2018 00:52
My suspicion is that the ternary operator (??:) cannot be inlined; it
gave completely bogus results. Fortunately, correct trigger bits were
recovered with max() function, which serves as logical OR operator in
this context.
…ltiple discriminators, added separate measType configs for B/C/UDSG, patched minor cmssw incompatibility
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

The code-checks are being triggered in jenkins.

@gpetruc
Copy link
Contributor

gpetruc commented Jul 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29021/console Started: 2018/07/05 18:04

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

Pull request #23446 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

@gpetruc
Copy link
Contributor

gpetruc commented Jul 5, 2018

+1
the only change wrt before is trivial

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23446/29021/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2899475
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2899280
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.9 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 1.900 KiB Physics/NanoAODDQM
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2018

+1

for #23446 355f35c

  • changes are in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show somewhat expected changes in the nanoAOD workflows

see more notes in #23446 (comment)

Based on the earlier discussion (#23446 (comment)), more changes will be necessary before the nanoAOD is ready for reprocessing the upcoming 80XLegacy reminiAOD

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 9, 2018

+1

@cmsbuild cmsbuild merged commit 2fd4547 into cms-sw:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.