Use global::EDAnalyzers in GeneratorInterface/Core #29328
Conversation
Only the .cc files need the module declaration.
|
The code-checks are being triggered in jenkins. |
|
FYI @makortel |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29328/14400
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/Core @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test workflow 1361.181 |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
| } // namespace gxsec | ||
|
|
||
| class GenXSecAnalyzer | ||
| : public edm::global::EDAnalyzer<edm::RunCache<gxsec::RunCache>, edm::LuminosityBlockCache<gxsec::LumiCache>> { |
There was a problem hiding this comment.
In #29098 is was essentially concluded that this module does not have to be run in RelVals or in production. Now that the module is made thread-efficient, the issue becomes moot and I'll close it.
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
. |
PR description:
The EDAnalyzers in GeneratorInterface/Core were either legacy or one::. GenXSecAnalyzer was prohibiting workflow 1361.181 from being able to use concurrent LuminosityBlocks efficiently.
Given that the two EDAnalyzers do no work on Event transitions (which is where we want the most thread-efficiency to be) using a std::mutex to only lock access at Lumi and Run transition will be fine.
As part of the change, I also removed the use of header files for the modules in the plugin directory.
PR validation:
The code compiles.