Ecal phase2 sim reco 11 1 x #29386

RSalvatico · 2020-04-03T09:54:42Z

PR description:

The PR contains the code necessary to run the Phase2 simulation of the EB (ECAL Barrel) calorimeter up to the digitisation step. Most of it was duplicated from the current code and adapted to describe the Phase2 configuration, which, for instance, should contain no references to EE (ECAL Endcap) and ES (ECAL Preshower). Thanks to the duplication, the newly introduced code DOES NOT affect standard simulation and reconstruction sequences in any way.

It is possible to select whether to use the Phase1 or Phase2 sequences when running an event generation (GEN,SIM, DIGI steps), by loading the Phase1 or Phase2 configuration files. An example is given by:

SimCalorimetry/EcalSimProducers/test/SingleElectron_cfi_py_GEN_IDEAL_withECALDigi_Ph1.py (Phase1)
SimCalorimetry/EcalSimProducers/test/SingleElectron_cfi_py_GEN_IDEAL_withECALDigi_newshape.py (Phase2)

When the Phase2 sequence is run, every signal in EB is sampled at 160 MHz for a total of 16 samples, according to the specifics of the Phase2 electronics. Two possible gains are applied to the signal samples: gain 10 and gain 1. The new EB digitisation is stored inside the simEcalUnsuppressedDigis collection, in which the digis are composed by 12 bits containing the ADC values (as for Phase1), plus a 13th bit containing the gain information: 0 if gain 10, 1 if gain 1.

PR validation:

The material included in the PR was validated mainly by generating particles (electrons) of different energies and checking how the signals they produced in EB were digitised. This was achieved by running the GEN,SIM,DIGI sequences in:

SimCalorimetry/EcalSimProducers/test/SingleElectron_cfi_py_GEN_IDEAL_withECALDigi_Ph1.py (Phase1)
SimCalorimetry/EcalSimProducers/test/SingleElectron_cfi_py_GEN_IDEAL_withECALDigi_newshape.py (Phase2)

and by reading their output files through the respective Phase1 and Phase2 analyzers, located in:

SimCalorimetry/PhaseIAnalyzer/
SimCalorimetry/PhaseIIAnalyzer/

The analyzers can be run with "cmsRun ConfFile_cfg.py", situated in the python/ folder of the two directories above. They produce a number of histograms, containing for instance the location of the signals as read by the EB electronics, and the gain they were read out with.
The tests showed that the desired digitisation behaviour was obtained for the Phase2 sequence, while the Phase1 behaviour still reflects the current one.

cmsbuild · 2020-04-03T09:54:58Z

@RSalvatico, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2020-04-03T09:55:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-03T09:59:40Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/14502

This PR adds an extra 248KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/14502/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/14502/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-04-03T17:12:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-03T17:19:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/14512

This PR adds an extra 284KB to repository

cmsbuild · 2020-04-03T17:19:55Z

A new Pull Request was created by @RSalvatico (Riccardo Salvatico) for master.

It involves the following packages:

CalibFormats/CaloObjects
CondFormats/DataRecord
CondFormats/EcalObjects
Configuration/StandardSequences
DataFormats/EcalDigi
SimCalorimetry/Configuration
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalSimProducers
SimCalorimetry/PhaseIAnalyzer
SimCalorimetry/PhaseIIAnalyzer
SimGeneral/MixingModule

The following packages do not have a category, yet:

SimCalorimetry/PhaseIAnalyzer
SimCalorimetry/PhaseIIAnalyzer
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@civanch, @silviodonato, @christopheralanwest, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @lecriste, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @argiro, @Martin-Grunewald, @rovere, @thomreis, @mmusich, @VinInn, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

civanch · 2020-04-05T09:48:39Z

please test

cmsbuild · 2020-04-05T09:49:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5541/console Started: 2020/04/05 11:56

cmsbuild · 2020-04-05T10:04:18Z

-1

Tested at: e0acded

CMSSW: CMSSW_11_1_X_2020-04-04-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c22a05/5541/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation warning when building: See details on the summary page.

Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2020-04-05T10:04:20Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-10-06T17:01:20Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/18827

This PR adds an extra 256KB to repository
Found files with invalid states:
- SimCalorimetry/EcalSimProducers/python/esCATIAGainProducer_cfi.py:
  - Added: 9ce2f7d, 0a9a0c2
  - Deleted: 9172b42
- Configuration/Eras/python/Era_Phase2_Ecal_Devel_cff.py:
  - Added: a43270b
  - Deleted: 2c927f7

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/18827/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/18827/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/18827/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/18827/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

slava77 · 2020-10-06T21:49:25Z

RecoJets/Configuration/python/RecoJets_EventContent_cff.py

                                           'keep floatedmValueMap_puppi_*_*',
                                           'keep *_ak4PFJetsPuppi_*_*',
                                           'keep *_ak8PFJetsPuppi_*_*',
                                           'keep *_ak8PFJetsPuppiSoftDrop_*_*',
-                                           'keep recoPFJets_ak4PFJets_*_*',


how is this related to ECAL phase 2 ?

slava77 · 2020-10-06T21:50:09Z

-1

this seems to contain some unrelated changes
e.g. RecoJets/Configuration/python/RecoJets_EventContent_cff.py

cmsbuild · 2020-10-08T07:36:55Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-08T07:44:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29386/18879

This PR adds an extra 20KB to repository
Found files with invalid states:
- SimCalorimetry/EcalSimProducers/python/esCATIAGainProducer_cfi.py:
  - Added: 9ce2f7d, 0a9a0c2
  - Deleted: 9172b42
- Configuration/Eras/python/Era_Phase2_Ecal_Devel_cff.py:
  - Added: a43270b
  - Deleted: 2c927f7
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Sub-event aware genJet and parton matching for HI miniAOD #31698, Bad PF candidate filter for 2018 PbPb data #31668
- File SimCalorimetry/EcalSimProducers/interface/EcalDigiProducer.h modified in PR(s): Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697
- File SimCalorimetry/EcalSimProducers/interface/EcalTimeDigiProducer.h modified in PR(s): Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697
- File SimCalorimetry/EcalSimProducers/src/EcalDigiProducer.cc modified in PR(s): Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697
- File SimCalorimetry/EcalSimProducers/src/EcalTimeDigiProducer.cc modified in PR(s): Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697

cmsbuild · 2020-10-08T07:45:10Z

Pull request #29386 was updated. @SiewYan, @andrius-k, @kpedro88, @jpata, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @santocch, @perrotta, @civanch, @yuanchao, @silviodonato, @ErnestaP, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @davidlange6, @tocheng, @jfernan2, @mdhildreth, @slava77, @ggovi, @qliphy, @fabiocos, @mkirsano, @kmaeshima, @christopheralanwest, @franzoni can you please check and sign again.

dariosol · 2020-10-08T07:47:43Z

Dear all,
I tried to force a push from the revision 11_2_0_pre3 to 11_1_0_pre4 on which the PR was open. Then I rebased the repo, but I think there are problems: if I try to recompile after the rebase i see errors like:

In file included from /afs/cern.ch/work/d/dsoldi/CMS/FromRiccardoForUpgrade/CMSSW_11_2_0_pre3/src/CondCore/SiPixelPlugins/plugins/SiPixelLorentzAngle_PayloadInspector.cc:15,
from /afs/cern.ch/work/d/dsoldi/CMS/FromRiccardoForUpgrade/CMSSW_11_2_0_pre3/src/CondCore/SiPixelPlugins/test/testSiPixelPayloadInspector.cpp:4:
/afs/cern.ch/work/d/dsoldi/CMS/FromRiccardoForUpgrade/CMSSW_11_2_0_pre3/src/CondCore/SiPixelPlugins/interface/SiPixelPayloadInspectorHelper.h:26:10: fatal error: DataFormats/TrackerCommon/interface/PixelBarrelName.h: No such file or directory
#include "DataFormats/TrackerCommon/interface/PixelBarrelName.h"

If I download the cmssw_11_1_0_pre4, and go in the EcalSimRecoPhase2_11_1_X (the one of the PR) and i try to compile it, I still see problems in compilation: it does not find the library fmt.

slava77 · 2020-10-08T13:52:39Z

-1

this seems to contain some unrelated changes
e.g. RecoJets/Configuration/python/RecoJets_EventContent_cff.py

thomreis · 2020-10-21T08:03:48Z

@dariosol can this PR be closed now that #31726 exists?

RSalvatico · 2020-10-21T10:00:54Z

@dariosol can this PR be closed now that #31726 exists?

Yes, we are closing this PR.

cmsbuild changed the base branch from CMSSW_11_1_X to master April 3, 2020 09:54

cmsbuild added this to the CMSSW_11_1_X milestone Apr 3, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending new-package-pending operations-pending orp-pending pending-signatures simulation-pending tests-pending labels Apr 3, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Apr 3, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 3, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 6, 2020

slava77 reviewed Oct 6, 2020

View reviewed changes

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Oct 6, 2020

This was referenced Oct 7, 2020

Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697

Merged

Sub-event aware genJet and parton matching for HI miniAOD #31698

Merged

Bad PF candidate filter for 2018 PbPb data #31668

Merged

Add code formats

56838fe

cmsbuild added code-checks-pending reconstruction-pending and removed code-checks-rejected reconstruction-rejected labels Oct 8, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 8, 2020

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Oct 8, 2020

cmsbuild mentioned this pull request Oct 9, 2020

Phase2 IT RechHit DQM and Validation modules #31666

Merged

dariosol mentioned this pull request Oct 9, 2020

Ecal phase2 new digitization 11 2 x #31726

Merged

cmsbuild mentioned this pull request Oct 19, 2020

Removed unused fwkJobReports from MessageLogger in GeneratorInterface Subsystem #31857

Merged

RSalvatico closed this Oct 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ecal phase2 sim reco 11 1 x #29386

Ecal phase2 sim reco 11 1 x #29386

RSalvatico commented Apr 3, 2020 •

edited

Loading

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

civanch commented Apr 5, 2020

cmsbuild commented Apr 5, 2020 •

edited

Loading

cmsbuild commented Apr 5, 2020

cmsbuild commented Apr 5, 2020

cmsbuild commented Oct 6, 2020

slava77 Oct 6, 2020

slava77 commented Oct 6, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

dariosol commented Oct 8, 2020

slava77 commented Oct 8, 2020

thomreis commented Oct 21, 2020

RSalvatico commented Oct 21, 2020

Ecal phase2 sim reco 11 1 x #29386

Ecal phase2 sim reco 11 1 x #29386

Conversation

RSalvatico commented Apr 3, 2020 • edited Loading

PR description:

PR validation:

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

cmsbuild commented Apr 3, 2020

civanch commented Apr 5, 2020

cmsbuild commented Apr 5, 2020 • edited Loading

cmsbuild commented Apr 5, 2020

cmsbuild commented Apr 5, 2020

cmsbuild commented Oct 6, 2020

slava77 Oct 6, 2020

Choose a reason for hiding this comment

slava77 commented Oct 6, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

dariosol commented Oct 8, 2020

slava77 commented Oct 8, 2020

thomreis commented Oct 21, 2020

RSalvatico commented Oct 21, 2020

RSalvatico commented Apr 3, 2020 •

edited

Loading

cmsbuild commented Apr 5, 2020 •

edited

Loading